[service] sync configured events instead of checking changes of all e… #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vents. Store event ids instead of names
Skosche3
force-pushed
the
fix-event-sync
branch
from
f9a44e6 to
ec07047
Compare
|
I think converting the ui calls to the event id is a better choice long term. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync configured events instead of checking changes of all events since there could be hundreds of events. See ObservationProcessor ln: 167
Store event ids instead of names. These changes support ability to look up this._eventRepo.findAllByIds to compare if configured event info has changed and requires syncing to arcGIS. Using MageEventId (alias of number type) instead ambiguity of number|string which can simplify code in places.
The cost of this change is index.ts having to convert incoming event names to ids upon saving configuration. We could avoid this with a UI change to send ids instead of names. Create a GitLab issue for UI work if agree that is a change worth doing.